Support fractional refresh rates in display modes #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Will implement ASAP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fractional display refresh rates for the virtual display. As shown here, the
DISPLAYCONFIG_VIDEO_SIGNAL_INFO'shSyncFreqandvSyncFreqcan be any rational number (integer numerator/denominator pairs). I set these appropriately in the driver code, as well as allowing the user to specify a numerator/denominator pair inoption.txtas they would when adding a new display resolution. For example,in
option.txtwould set up a 1920x1080 59.94Hz display option.This change works fine in my testing (Windows 10 19045), but I don't have a Windows 11 PC or an HDR display to test with so I only changed the Non-HDR driver code. I can do the same change for the HDR driver code but I can't test it. This is also my first time working with driver code so it may be possible I missed something important - please let me know if that is the case.
Closes #109.