-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function to print comic information to STDOUT #12
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be cool to offer it as an option to forgo the popup i.e. just get that metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to ISO date format
I tried to make the data optional, but again it's my first time touching python and I didn't have any luck adding the necessary flag EDIT: Also, would foregoing the pop-up make sense in combination with the |
Ok, I figured it out. I've added the flags |
Maybe at least print the comic number no matter what? That would make issues like #8 reproducible. |
This is great for your first time with Python btw! The only stuff I wrote back then was garbage |
Done! And Thanks. I'm reasonably competent with bash script, so I've got the basic scripting logic, and it's mostly just extrapolating from what's already there to get the syntax. I appreciate the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I thought it would be nice to have comic information (Title, Publish Date, Number, and Alt Text) written to the terminal output. Sorry if there's a better way to do this, it's the first time I've ever touched Python code.