Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsers: Fix parsing live_now and premiere_timestamp #4934

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

absidue
Copy link
Contributor

@absidue absidue commented Sep 20, 2024

Related to #4929

This pull request fixes the parsing for the live_now and premiere_timestamp variables so that they work without the microformat data being present.

Testing live_now:
/api/v1/videos/jfKfPfyJRdk -> type should be "livestream" and liveNow should be true

Testing premiere_timestamp:

  1. Go to https://www.youtube.com/live and pick a video from the Upcoming Live Streams section
  2. /api/v1/videos/{videoID} => should return a HTTP 500 status code and the following json {"error":"This live event will begin in 56 minutes."}

@absidue absidue requested a review from a team as a code owner September 20, 2024 16:44
@absidue absidue requested review from syeopite and removed request for a team September 20, 2024 16:44
@syeopite syeopite added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Oct 4, 2024
@SamantazFox SamantazFox added in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Oct 7, 2024
@SamantazFox SamantazFox added ready and removed in-testing This feature has been deployed and is being tested labels Nov 9, 2024
@SamantazFox SamantazFox changed the title Fix parsing live_now and premiere_timestamp Parsers: Fix parsing live_now and premiere_timestamp Nov 10, 2024
@SamantazFox SamantazFox merged commit 4b363e3 into iv-org:master Nov 10, 2024
8 checks passed
@SamantazFox
Copy link
Member

Thanks again for contributing :)

@absidue absidue deleted the fix-live-now-premiere-timestamp branch November 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants