Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply upcoming formatting rules from Crystal 1.15 #5014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syeopite
Copy link
Member

@syeopite syeopite commented Oct 18, 2024

Fixes CI on nightly.

Crystal Nightly recently enabled a bunch of new formatting rules that will be introduced in the upcoming Crystal 1.15 release.

These changes are backwards compatible and as such the CI should pass on older Crystal versions.

crystal-lang/crystal#14718

@syeopite syeopite requested a review from a team as a code owner October 18, 2024 18:37
@syeopite syeopite requested review from unixfox and removed request for a team October 18, 2024 18:37
@syeopite syeopite force-pushed the crystal-nightly-formatter-changes branch 2 times, most recently from c93a202 to 70243c8 Compare October 18, 2024 18:45
@syeopite
Copy link
Member Author

syeopite commented Oct 18, 2024

Save for the changes in src/invidious/videos/storyboard.cr everything seems to be backwards compatible

@syeopite syeopite force-pushed the crystal-nightly-formatter-changes branch from 70243c8 to 0cce233 Compare October 18, 2024 19:37
@syeopite syeopite added the blocked require something else first label Oct 25, 2024
@syeopite syeopite force-pushed the crystal-nightly-formatter-changes branch from 0cce233 to e71bcc8 Compare November 8, 2024 04:14
@syeopite
Copy link
Member Author

syeopite commented Nov 8, 2024

Blocked until the release of Crystal 1.14.1

See crystal-lang/crystal#15097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked require something else first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant