Add parameter cron for disabling checks not useful when being instantiated by CRON #25
Conversation
|
@WardPearce if you can review what I have done :). thank you |
Yes can do, on holiday currently but will check this briefly |
smart_ipv6_rotator/__init__.py
Outdated
| @@ -58,6 +58,13 @@ | |||
| "help": "Completely disables the --services flag.", | |||
| }, | |||
| ), | |||
| ( | |||
| "--cron", | |||
There was a problem hiding this comment.
Probably shouldn't be a shared parameter, as only used for run.
There was a problem hiding this comment.
What do you mean by that?
There was a problem hiding this comment.
"SHARED_OPTIONS" is options what are shared between multiple commands.
If a option is only specific to a command, it should prob be added like so https://github.com/iv-org/smart-ipv6-rotator/blob/skip-http-checks-cron/smart_ipv6_rotator/__init__.py#L266
There was a problem hiding this comment.
thanks. I moved to a static option.
|
Following needs to be updated too Line 60 in 677835d |
This will help with these issues:
Basically, the HTTP check may not be useful if the script is launched by CRON because the HTTP check is only for telling people that their setup does not work.
People can disable this check by passing
--cron.