Speed up metrics computation by parallelizing across subjects #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial attempt at parallelizing the computation of metrics across subjects using
multiprocessing
. The usage is similar to that ofsct_run_batch
-- an additional arg-jobs
has been added to process subjects in parallel.I even tried parallelizing across labels (i.e. nested parallelization with 1st parallelism across subjects and 2nd level of parallelism across labels for each subject). BUT, this resulted in an error
AssertionError: daemonic processes are not allowed to have children
-- which essentially means that child processes are not allowed to create further child processes.Hence, in this version, parallelization is only happening at one level. If we want to parallelize the computation across multiple subjects, we should avoid parallelizing within each subject's computation (i.e. no parallelization within the labels).
@valosekj could you please give this PR a try and see if you see some speed ups?
Related: #10