Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LesionCountWeightedByAssignment, RefLesionsCount, PredLesionsCount #6

Merged
merged 16 commits into from
Jun 7, 2024

Conversation

valosekj
Copy link
Member

@valosekj valosekj commented Jun 6, 2024

@naga-karthik lmk once the PR is ready for review

Resolves #4

@naga-karthik
Copy link
Member

hey @valosekj it is now ready for review! (for some reason, I am unable to add you as a reviewer)

@naga-karthik naga-karthik assigned valosekj and unassigned valosekj Jun 7, 2024
@valosekj
Copy link
Member Author

valosekj commented Jun 7, 2024

Thanks @naga-karthik! Tested and LGTM! I have just fixed a mission comma in 7f413e8. And clarified some comments in my other commits.
I also added ref_count and pred_count to unit tests in 3dc77ca. And added tests for multiple lesions in e6c6596.
Finally, I also fixed the CI in 52b69f8!

compute_metrics_reloaded.py Outdated Show resolved Hide resolved
@naga-karthik
Copy link
Member

looks good ; merging!

@naga-karthik naga-karthik merged commit e96566a into main Jun 7, 2024
3 checks passed
@naga-karthik naga-karthik deleted the nk/add-lcwa-lesion-counts branch June 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add lesion counts to the package and output in CSV
2 participants