Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_for_correction.py - move to SCT? #16

Closed
wants to merge 2 commits into from

Conversation

valosekj
Copy link
Member

@valosekj valosekj commented Jan 6, 2023

I needed to package data for manual correction for the INSPIRED project. I did not want to duplicate scripts; thus, I used the package_for_correction.py from this CanProCo repo. To make the script compatible with INSPIRED's filenames (e.g., sub-torontoDCM001_acq-cspineAxial_T2w.nii.gz), I had to make get_subject and get_ses functions more robust. Namely, I used regular expressions instead of the .split method in 2f06bf4.

Also, for the INSPIRED project, I'm currently using the _label-SC_mask.nii.gz suffix instead of _seg.nii.gz (as discussed here). For this reason, I added an optional argument to the package_for_correction.py script in 5c5e2ac.

Since the package_for_correction.py script is more universal and can be used for any project, maybe, we could implement that into the SCT?

For the context, package_for_correction.py was first introduced for spine-generic.

Note: I realize that this PR is not relevant to CanProCo itself, but I wanted to discuss this somewhere. After talking about it, the PR can be closed without merging.

@valosekj valosekj changed the title package_for_correction.py - get_subject and get_ses functions more robust package_for_correction.py - move to SCT? Jan 6, 2023
@valosekj
Copy link
Member Author

Closing since manual correction scripts will be integrated under separate repo

@valosekj valosekj closed this Jan 20, 2023
@valosekj valosekj deleted the jv/make_get_subject_and_get_ses_more_robust branch February 3, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant