Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nibabel is sort of convoluted, but you can see here it has this
mmap
parameter:It looks like they turned it on by default, with the assumption that it was a performance boost, but I think on the NVMe drive on
romane
it might be holding us back by triggering thousands of tiny I/Os in parallel. The NVMe drive apparently can handle 400MB/s (maybe more), but not when we force it to give us individual values in the order we ask for them, which I suspect mmap() is probably implicitly doing.https://stackoverflow.com/questions/9817233/why-mmap-is-faster-than-sequential-io
This is all a big guess but it is an attempt to fix https://github.com/neuropoly/computers/issues/371.
I don't know if this should become a permanent part of ivadomed, but I would like you to test to see if it improves performance on our hardware.