Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat docker #13

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Feat docker #13

merged 3 commits into from
Oct 17, 2023

Conversation

ivan0dyatlyukkk
Copy link
Owner

No description provided.

ArtemReizer
ArtemReizer approved these changes Sep 28, 2023
View reviewed changes
Copy link

@ArtemReizer ArtemReizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vovasalyha
vovasalyha approved these changes Sep 29, 2023
View reviewed changes
Copy link

@vovasalyha vovasalyha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, but try avoiding adding changes unrelated to the current PR

Dockerfile
COPY --from=builder application/snapshot-dependencies/ ./
COPY --from=builder application/application/ ./
ENTRYPOINT ["java", "org.springframework.boot.loader.JarLauncher"]
EXPOSE 8080
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

@ivan0dyatlyukkk ivan0dyatlyukkk changed the base branch from feat-order to feat-order-new October 17, 2023 12:06
@ivan0dyatlyukkk ivan0dyatlyukkk changed the base branch from feat-order-new to main October 17, 2023 12:09
@ivan0dyatlyukkk ivan0dyatlyukkk merged commit 057049e into main Oct 17, 2023
3 checks passed
@ivan0dyatlyukkk ivan0dyatlyukkk deleted the feat-docker branch October 17, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vovasalyha vovasalyha vovasalyha approved these changes

@ArtemReizer ArtemReizer ArtemReizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan0dyatlyukkk @vovasalyha @ArtemReizer