Tested shopping cart functionality #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ivan0dyatlyukkk
commented
Oct 23, 2023
ivan0dyatlyukkk
commented
andrii-hoienko
suggested changes
Oct 24, 2023
| void findById_withValidId_returnsCartItem() { | ||
| CartItem actualCartItem = cartItemRepository.findById(TEST_VALID_CART_ITEM_ID).get(); | ||
|
|
||
| assertNotNull(actualCartItem.getShoppingCart()); |
There was a problem hiding this comment.
Are you sure that is it enough to assert that shopping cart is not null, maybe makes sence to check content of cart?And actually make sure that you have at least one tets which checks content of something that you receive
There was a problem hiding this comment.
It is not resolved, at least in CartControllerTest you don`t have assert where content of cart is checked fullt
There was a problem hiding this comment.
You are completely right, sorry, I added it to the next method and forgot to add to this one
andrii-hoienko
suggested changes
Oct 27, 2023
| void findById_withValidId_returnsCartItem() { | ||
| CartItem actualCartItem = cartItemRepository.findById(TEST_VALID_CART_ITEM_ID).get(); | ||
|
|
||
| assertNotNull(actualCartItem.getShoppingCart()); |
There was a problem hiding this comment.
It is not resolved, at least in CartControllerTest you don`t have assert where content of cart is checked fullt
vovasalyha
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.