Skip to content

Commit

Permalink
feat(android):RN-0.73 and AGP 8.0 Compatibility (#2018)
Browse files Browse the repository at this point in the history 
* RN-0.73 and AGP 8.0 Compatibility

* RN-0.73 and AGP 8.0 Compatibility: Update AndroidManifest.xml
  • Loading branch information
@dishantwalia
dishantwalia authored Oct 7, 2024
1 parent 4d9cb70 commit 47fcfea
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 4 additions & 0 deletions android/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ android {
lintOptions {
abortOnError false
}
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.reactnative.ivpusic.imagepicker"
}
}

dependencies {
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.reactnative.ivpusic.imagepicker">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<queries>
<intent>
Expand Down

4 comments on commit 47fcfea

@mdNazmulHasan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dishantwalia it seems like removing the package name from the manifest is creating issue while trying to "pod install" .

@maximizing
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found error Package Name not found in AndroidManifest.xml on Android and everything is fine on iOS

@mdNazmulHasan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my podfile the following line is available,
use_native_modules!
Probably that's why when I try to run pod install, the error gets displayed regarding package name.

@yangci
Copy link

@yangci yangci commented on 47fcfea Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing package names from AndroidManifest.xml causes an error when running npx react-native config, resulting in pod install failing on version 0.41.3 of iOS.

Please sign in to comment.