Fixed exceptions in some JDBC drivers when working with chars #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Bo98 tried to ping you via your email. Any interest in becoming an ormlite maintainer? Not a ton of extra work but I'd love to get another pair of eyes on it. Please ping me at my contact form. https://256stuff.com/gray/email/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all JDBC drivers support
java.lang.Character(for whatever reason). Notably MariaDB, Oracle and SQL Server. I've added aFieldConverterto convert the SQL arg into a String which is accepted by all 3 (+ 1 for JTDS) JDBC drivers. Note that the underlying SQL type remains unchanged so this should have no backwards compatibility concerns.The new
CharacterCompatFieldConvertercurrently resides in this repository but it should probably be moved into ormlite-core. Perhaps into a new packagecom.j256.ormlite.field.converterswhere we can also moveBooleanNumberFieldConvertertoo (currently resides inBaseDatabaseType).This fixes some exceptions first reported in issue #2.