Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: generify storage backend #55

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from
Draft

Refactor: generify storage backend #55

wants to merge 59 commits into from

Conversation

ja-he
Copy link
Owner

@ja-he ja-he commented Jul 27, 2024

No description provided.

@ja-he ja-he self-assigned this Jul 27, 2024
@ja-he ja-he marked this pull request as draft August 4, 2024 20:08
ja-he added 26 commits August 10, 2024 14:48
@ja-he
test(providers): Add a basic files provider test
254b068
@ja-he
fixup! use event IDs
2094e5e
@ja-he
log a bit more
3e399ad
@ja-he
fixup! implement event-querying over daywise file handlers in provider
4ce6df8
@ja-he
fixup! implement get-before/-after for basic event switching
2fd9cad
@ja-he
fixup! test(providers): Add a basic files provider test
8159070
@ja-he
fix(FilesProvider): Get events not by iterating all dates in range
5c7e713 
This was a silly approach; since we have getAvailableDates we
leverage that to only iterate the dates we have which in realistic
use cases should reduce the load and certainly avoids some terrible
cases.
@ja-he
doc(provider): Document a good bit of the provider interface
5f2e2e0
@ja-he
fixup! fix various aspects of event switching
604e70d
@ja-he
fix(FilesProvider): check start/end relation when setting start/end
cebdde0
@ja-he
fix(FilesProvider): Avoid changing events when set times are wrong
151f056
@ja-he
test(FilesProvider): Test SetEventStart
1bbaf2c
@ja-he
test(FilesProvider): Test RemoveEvent and SetEventEnd
93c93c6
@ja-he
implement OffsetEvent{Start,End}
73c1119
@ja-he
test(FilesProvider): Test time-offsetting functions
4a8477c
@ja-he
fixup: fix assert.Equal arg order
e6f8f20
@ja-he
fixup: fix invalid duration offset test
9a07695
@ja-he
fix(FilesProvider): Get prev/next event across dates even with empty …
64ea540 
…date between

Previously, if there was a file handler for a prev/next date that
did not have events, the nil would blindly be returned, instead of
checking further handlers.
@ja-he
test(FilesProvider): Add tests for getting preceding/following event
e8bfd8e
@ja-he
test(FilesProvider): Test GetEvent{Before,After}
24fcf3e
@ja-he
test(FilesProvider): add basic tests for snapping
12f5865
@ja-he
fixup! test(FilesProvider): add basic tests for snapping
c9a373a
@ja-he
fix(FilesProvider): Fix snapping implementations
13efb19
@ja-he
feat(FilesProvider): Implement and test SplitEvent
d664a4f
@ja-he
feat(FilesProvider): Implement SetEventTimes
ada8aa4
@ja-he
test(FilesProvider): test SetEventTimes
6fcde64
@ja-he ja-he force-pushed the refactor-generify-storage-backend branch from 6fddf32 to 6fcde64 Compare August 16, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ja-he ja-he

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ja-he