Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tracer supports MultiQueryTracer #1976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uh-zz
Copy link

@uh-zz uh-zz commented Mar 31, 2024

It able to set tracer and logger respectively.

#1950

@jackc
Copy link
Owner

jackc commented Apr 16, 2024

As I mentioned on my comment to #1950:

One thing I would be concerned about is how to handle multiple tracers that each implement different hooks. I'm sure it could be handled but it might be a little tricky to both have a clean interface and avoid a performance hit.

As far as I can tell this does not account for this case at all. What if one of tracers implemented pgx.BatchTracer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants