Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable composite tests on cockroachdb #2028

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable composite tests on cockroachdb #2028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f4cbb
Upgrade CockroachDB on CI
jackc May 25, 2024
2975119
Test composites on CockroachDB
jackc May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/setup_test.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ fi

if [[ "${PGVERSION-}" =~ ^cockroach ]]
then
wget -qO- https://binaries.cockroachdb.com/cockroach-v23.1.3.linux-amd64.tgz | tar xvz
sudo mv cockroach-v23.1.3.linux-amd64/cockroach /usr/local/bin/
wget -qO- https://binaries.cockroachdb.com/cockroach-v23.2.5.linux-amd64.tgz | tar xvz
sudo mv cockroach-v23.2.5.linux-amd64/cockroach /usr/local/bin/
cockroach start-single-node --insecure --background --listen-addr=localhost
cockroach sql --insecure -e 'create database pgx_test'
fi
Expand Down
10 changes: 0 additions & 10 deletions pgtype/composite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
)

func TestCompositeCodecTranscode(t *testing.T) {
skipCockroachDB(t, "Server does not support composite types (see https://github.com/cockroachdb/cockroach/issues/27792)")

defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {

_, err := conn.Exec(ctx, `drop type if exists ct_test;
Expand Down Expand Up @@ -91,8 +89,6 @@ func (p *point3d) ScanIndex(i int) any {
}

func TestCompositeCodecTranscodeStruct(t *testing.T) {
skipCockroachDB(t, "Server does not support composite types (see https://github.com/cockroachdb/cockroach/issues/27792)")

defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {

_, err := conn.Exec(ctx, `drop type if exists point3d;
Expand Down Expand Up @@ -128,8 +124,6 @@ create type point3d as (
}

func TestCompositeCodecTranscodeStructWrapper(t *testing.T) {
skipCockroachDB(t, "Server does not support composite types (see https://github.com/cockroachdb/cockroach/issues/27792)")

defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {

_, err := conn.Exec(ctx, `drop type if exists point3d;
Expand Down Expand Up @@ -169,8 +163,6 @@ create type point3d as (
}

func TestCompositeCodecDecodeValue(t *testing.T) {
skipCockroachDB(t, "Server does not support composite types (see https://github.com/cockroachdb/cockroach/issues/27792)")

defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {

_, err := conn.Exec(ctx, `drop type if exists point3d;
Expand Down Expand Up @@ -214,8 +206,6 @@ create type point3d as (
//
// https://github.com/jackc/pgx/issues/1576
func TestCompositeCodecTranscodeStructWrapperForTable(t *testing.T) {
skipCockroachDB(t, "Server does not support composite types (see https://github.com/cockroachdb/cockroach/issues/27792)")

defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {

_, err := conn.Exec(ctx, `drop table if exists point3d;
Expand Down
Loading