Add support for PG 17 interval infinity values #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in this commit: postgres/postgres@519fc1bd9 The wire format for infinity/-infinity adds no breaking changes- it is just the various values set to either minimum or maximum possible int64/int32 values. I attempted to match how InfinityModifier works in other types, such as date and timestamptz.
toofishes
commented
Jun 29, 2024
| Microseconds int64 | ||
| Days int32 | ||
| Months int32 | ||
| InfinityModifier InfinityModifier |
There was a problem hiding this comment.
Is it worth adding a field comment here along the lines of this?
// InfinityModifier for intervals is only supported in Postgres 17 or newer
InfinityModifier InfinityModifier
jackc
approved these changes
Jun 29, 2024
| Microseconds int64 | ||
| Days int32 | ||
| Months int32 | ||
| InfinityModifier InfinityModifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Postgres 17 is still in beta, I thought it might make sense to get ahead of one of the changes being made.
Added in this commit: postgres/postgres@519fc1bd9
Upstream release notes: https://www.postgresql.org/docs/17/release-17.html#RELEASE-17-DATATYPES
The wire format for infinity/-infinity adds no breaking changes- it is just the various values set to either minimum or maximum possible int64/int32 values.
I attempted to match how InfinityModifier works in other types, such as date and timestamptz.
Please let me know what, if anything, I forgot to update here, and any other feedback is definitely welcome.
It feels like this is relatively safe and backward compatible with older versions, since you can just choose not to use infinity values with older versions, and since there were no wire format changes. However, I'm happy to make changes or documentation updates if that is necessary.