Skip to content
This repository has been archived by the owner on Nov 25, 2017. It is now read-only.

Changed .html to .rst to fix links #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nqobile
Copy link

@nqobile nqobile commented Jun 3, 2014

Fixed the links at the end of the page that link to Chapter 14 and Chapter 16. The links are actually jacobian/djangobook.com/blob/master/chapter14.rst and jacobian/djangobook.com/blob/master/chapter16.rst not ../chapter14.html and ../chapter16.html, respectively.

Fixed the links at the end of the page that link to Chapter 14 and Chapter 16. The links are actually jacobian/djangobook.com/blob/master/chapter14.rst and jacobian/djangobook.com/blob/master/chapter16.rst not ../chapter14.html and ../chapter16.html, respectively.
@treyhunner
Copy link

Hey @nqobile!

Disclaimer: I am not one of the maintainers of this project. If @jacobian or one of the other maintainers wants to step in and correct or verify my interpretation, please do so.

From my understanding pull requests #77 through #96 cannot be accepted by this project. This is because the djangobook.com project files are used to generate the website http://www.djangobook.com/ and are primarily meant to be read from the djangoproject.com website and not from Github. Your changes seem to introduce a book on that website.

Here's the process I used to verify that your changes won't work out for the djangoproject.com website:

  1. I cloned your repository and checked out one of your pull requests to try to build the project locally:

    git clone [email protected]:nqobile/djangobook.com.git
    cd djangobook.com
    git checkout patch-6
    
  2. I built the project locally:

    sudo pip install Sphinx  # I didn't have Sphinx installed
    make html
    
  3. I opened the file _build/html/chapter06.html in Chrome and clicked on the Chapter 7 link at the bottom of the page. The link took me to chapter07.rst (which gave me a 404 error) instead of chapter07.html.

Thanks for trying your hand at contributing. I'm sorry no one said anything a few hours ago while you were in the process of making your contributions. I was away from my computer at the time.

@nqobile
Copy link
Author

nqobile commented Jun 5, 2014

@treyhunner

That makes sense. I was using djangobook.com trying to understand Django 1.6, but their disclaimer on the page led me to think that they were now pointing people to this repository for newer versions of Django. Since their disclaimer is still on the website I didn't think that they were using these files to generate the content for the book.

@suhailvs
Copy link

@nqobile yes they were using these files to generate the content of djangobook.com. it is by sphinx. please see my fork https://github.com/suhailvs/djangobook.com. you can see its sphinx generated pages at http://suhailvs.github.io/djangobook.com/. I am planning to maintain the book, since it is a great book and helped me alot.. so feel free to fork mine and send me pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants