[fix]: de-duplicate redux and react-redux dependencies #2547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
react-redux
andredux
Description of the changes
Here's what went wrong:
/root/package.json
/root/package-lock.json
/root/packages/jaeger-ui/package.json
/root/packages/plexus/package.json
Currently, when we run
npm ci
ornpm install
, the packages listed in /root/packages/jaeger-ui/package.json and /root/packages/plexus/package.json are saved to a folder /root/node_modulesWhy is that?
The current package-lock.json contains references to packages in the form which translates to npm that these dependencies are used by /root workspace. For example, in redux, we had
"node_modules/redux":
.How it should have been?
The package-lock.json should contain references to workspace package, eg.
"packages/jaeger-ui/node_modules/redux":
This would translate to
npm
that this package has to be installed insideroot/packages/jaeger-ui/node_modules
folder.How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test