[fix]: Remove redux-form dependency from Monitor page #2562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
redux-form
.redux-form
in this same PR. Neither have I removedredux-form
package as of now.Antd
SearchableSelect
requires loading type to beboolean | undefined
so I have changed the related types in other files to fix ts-lint errors.Why this change was needed?
redux-form
is anyway deprecating so in-built react state management is a good choice.state
object for state management, andprops
for injecting props to the component.redux-form
use to inject those Dropdown Selector valuesselectedService
,selectedSpanKind
, andselectedTimeFrame
from redux store.How was this change tested?
npm run test
npm run start
with monitor page view. everything seems to be working fine.Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test