Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Remove redux-form dependency from Monitor page #2562

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

hari45678
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • This PR removes dependency of Monitor page on redux-form.
  • To keep this PR small and easy to review, I haven't removed other instances of redux-form in this same PR. Neither have I removed redux-form package as of now.
  • Antd SearchableSelect requires loading type to be boolean | undefined so I have changed the related types in other files to fix ts-lint errors.

Why this change was needed?

  • Monitor page has a few selectors that doesn't need any global state sync to other components. redux-form is anyway deprecating so in-built react state management is a good choice.
  • React uses state object for state management, and props for injecting props to the component. redux-form use to inject those Dropdown Selector values selectedService, selectedSpanKind, and selectedTimeFrame from redux store.
  • This PR moves that to in-built react state, so we won't have to inject those from store anymore.

How was this change tested?

  • npm run test
  • npm run start with monitor page view. everything seems to be working fine.

Checklist

@hari45678 hari45678 requested a review from a team as a code owner January 7, 2025 17:29
@hari45678 hari45678 requested review from mahadzaryab1 and removed request for a team January 7, 2025 17:29
Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (73a16c0) to head (6557be0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2562   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7728     7731    +3     
  Branches     1950     2010   +60     
=======================================
+ Hits         7468     7471    +3     
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 8, 2025
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro changed the title [fix]: remove redux-form dependency from Monitor page [fix]: Remove redux-form dependency from Monitor page Jan 8, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 8, 2025 03:40
@yurishkuro yurishkuro merged commit c28adbb into jaegertracing:main Jan 8, 2025
7 checks passed
@hari45678 hari45678 deleted the remove-redux-form branch January 9, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants