Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add Span Kind support for ES/OS #6399

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Manik2708
Copy link
Contributor

Which problem is this PR solving?

Fixes: #1923

Description of the changes

  • While querying GetOperations, operations can now be fetched with kind also. When kind kept empty, spans of all kinds are returned

How was this change tested?

  • Unit and E2E tests

Checklist

@Manik2708 Manik2708 requested a review from a team as a code owner December 24, 2024 13:40
@Manik2708 Manik2708 requested a review from jkowall December 24, 2024 13:40
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 18 lines in your changes missing coverage. Please review.

Project coverage is 96.17%. Comparing base (53468aa) to head (02bff1c).

Files with missing lines Patch % Lines
plugin/storage/es/spanstore/service_operation.go 82.85% 12 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6399       +/-   ##
===========================================
+ Coverage   49.57%   96.17%   +46.59%     
===========================================
  Files         182      366      +184     
  Lines       11190    21030     +9840     
===========================================
+ Hits         5548    20226    +14678     
+ Misses       5197      613     -4584     
+ Partials      445      191      -254     
Flag Coverage Δ
badger_v1 8.90% <0.00%> (-0.08%) ⬇️
badger_v2 1.82% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v1-manual 14.80% <0.00%> (-0.12%) ⬇️
cassandra-4.x-v2-auto 1.77% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2-manual 1.77% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v1-manual 14.80% <0.00%> (-0.12%) ⬇️
cassandra-5.x-v2-auto 1.77% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2-manual 1.77% <0.00%> (-0.02%) ⬇️
elasticsearch-6.x-v1 18.95% <56.75%> (+0.33%) ⬆️
elasticsearch-7.x-v1 19.02% <56.75%> (+0.34%) ⬆️
elasticsearch-8.x-v1 19.17% <56.75%> (+0.33%) ⬆️
elasticsearch-8.x-v2 1.81% <0.00%> (-0.03%) ⬇️
grpc_v1 10.55% <0.00%> (-0.09%) ⬇️
grpc_v2 8.06% <0.00%> (-0.07%) ⬇️
kafka-v1 9.25% <0.00%> (-0.08%) ⬇️
kafka-v2 1.82% <0.00%> (-0.02%) ⬇️
memory_v2 1.82% <0.00%> (-0.02%) ⬇️
opensearch-1.x-v1 19.07% <56.75%> (+0.34%) ⬆️
opensearch-2.x-v1 19.06% <56.75%> (+0.33%) ⬆️
opensearch-2.x-v2 1.81% <0.00%> (-0.02%) ⬇️
tailsampling-processor 0.46% <0.00%> (-0.01%) ⬇️
unittests 95.02% <81.08%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES storage plugin: query service to support spanKind when retrieve operations for a given service
1 participant