Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish speed cap implementation #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Finish speed cap implementation #47

wants to merge 1 commit into from

Conversation

ror3d
Copy link

@ror3d ror3d commented Jul 7, 2017

Changed the speed cap max to 2GB. For that I added the uiSyncFixedInt function to utils.c

Fixed the implementation for the buffer so it is maxed at both number of messages and size of the buffer, to avoid bufferbloating. The macro ALLOW_SET_BUFFER_SIZE can be set to allow the user to select the size of the buffer. If left unchecked, a quarter of the speed per second is used (as per common practices).

The buffering/dropping was done for both inbound and outbound packets once it had started. Changed to a packet per packet model to allow for only one direction capping.

Fixed a crash when dropping packets because they weren't popped from the list.

@jagt
Copy link
Owner

jagt commented Jul 12, 2017

Thanks a lot!
I'll try to integrate this into the next release when I got time.

@VAllens
Copy link

VAllens commented Jul 8, 2024

Is there any progress on this pull request?

@ror3d
Copy link
Author

ror3d commented Jul 19, 2024

Definitely not from me, and it seems the files in the project haven't had any update in the last 3 years, so I wouldn't count on this happening anytime soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants