Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding LIS in kotlin #2336

Closed
wants to merge 2 commits into from
Closed

Adding LIS in kotlin #2336

wants to merge 2 commits into from

Conversation

shubhammantri1
Copy link
Contributor

@shubhammantri1 shubhammantri1 commented Mar 8, 2020 •
edited
Loading

Fixes #2253

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Changes proposed in this pull request:

  • Longest_Increasing_Subsequence in Kotlin

Languages Used:

  • Kotlin

Files Added:

  • LIS.kt

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

@shubhammantri1
Copy link
Contributor Author

@jainaman224 @SakshiShreya Please review my PR.

jainaman224
jainaman224 requested changes Mar 11, 2020
View reviewed changes
Longest_Increasing_Subsequence/LIS.kt Outdated
@@ -0,0 +1,51 @@
import java.util.*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be Longest_Increasing_Subsequence.kt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do so because All other files have the same name LIS. If you still want I can change.

Longest_Increasing_Subsequence/LIS.kt Outdated
@@ -0,0 +1,51 @@
import java.util.*

fun main(){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space before {.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Longest_Increasing_Subsequence/LIS.kt Outdated
println("Size of the longest increasing subsequence: $max")
}

/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong that's why colouring is distorted. Please have a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shubhammantri1
Copy link
Contributor Author

@jainaman224 @SakshiShreya Please review my PR. I made all require changes.

@shubhammantri1
Copy link
Contributor Author

@jainaman224 @SakshiShreya @raghav-dalmia @somya-kapoor Please review my PR. It's been more than a week.

@shubhammantri1 shubhammantri1 deleted the lis branch March 22, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainaman224 jainaman224 jainaman224 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Longest Increasing Subsequence
2 participants
@shubhammantri1 @jainaman224