Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #2384

Closed
wants to merge 3 commits into from
Closed

update #2384

wants to merge 3 commits into from

Conversation

shwetachan
Copy link

Fixes #2253

Checklist:

  • [ Y] 4 space indentation.
  • [Y ] Coding conventions are followed.
  • Input is taken dynamically.
  • [Y ] Sample Input / Output is added at the end of file.
  • [ Y] Logic Documentation (Comments).
  • [ Y] File names are correct.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Changes proposed in this pull request:

  • javascript update
  • C update

Languages Used:

  • C
  • JS in each file

Files Added:

  • LIS_C.cpp
  • LIS.js

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

this file shows how brute force can be applied to solve the longest increasing sequence problem.
@shwetachan shwetachan closed this Mar 10, 2020
@shwetachan shwetachan reopened this Mar 10, 2020
@asha15
Copy link
Collaborator

asha15 commented Mar 13, 2020

you was assigned to create only from JS . could you please remove the cpp file?

@SakshiShreya
Copy link
Collaborator

SakshiShreya commented Mar 19, 2020

Also, complete the PR template and write an appropriate title for the PR.

Copy link
Collaborator

@SakshiShreya SakshiShreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the PR template properly.

* @return {number}
*/
export default function dpLongestIncreasingSubsequence(sequence) {
// Create array with longest increasing substrings length and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 spaces for indentation.

}

return longestIncreasingLength;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add sample input and output at the EOF.

@somya-kapoor
Copy link
Collaborator

Are you working on it?

@somya-kapoor
Copy link
Collaborator

Due to no activity for more than 7 days, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longest Increasing Subsequence
4 participants