Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #818

Merged
merged 4 commits into from
May 24, 2024
Merged

Updates #818

merged 4 commits into from
May 24, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented May 21, 2024 •
edited
Loading

  • move from 5.0.1.Alpha1-SNAPSHOT to 5.0.0.Alpha1-SNAPSHOT
  • move the base Java level to 17
  • move a few forgotten references from 4.1 to 5.0
  • remove deprecated methods from BeanManager

manovotn
manovotn previously approved these changes May 21, 2024
View reviewed changes
@manovotn
Copy link
Contributor

move from 5.0.1.Alpha1-SNAPSHOT to 5.0.0.Alpha2-SNAPSHOT

Shouldn't this be 5.0.0.Alpha1-SNAPSHOT?

@manovotn manovotn dismissed their stale review May 21, 2024 15:29

Too hasty from me

manovotn
manovotn requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are removing the BM methods, we should be able to also remove the EL dep from CDI API pom.xml and only keep it in the CDI EL API.

api/src/main/java/jakarta/enterprise/inject/spi/BeanManager.java Show resolved Hide resolved
@Ladicek Ladicek force-pushed the updates branch 2 times, most recently from c82dcad to 29a4a2b Compare May 22, 2024 07:12
@Ladicek
Copy link
Contributor Author

Ladicek commented May 22, 2024

Shouldn't this be 5.0.0.Alpha1-SNAPSHOT?

That's what I also thought, but there have apparently been several attempts to release 5.0.0.Alpha1 already. None of them appeared in Maven Central, but the commits are there. Not sure what to do about this...?

@manovotn
Copy link
Contributor

Shouldn't this be 5.0.0.Alpha1-SNAPSHOT?

That's what I also thought, but there have apparently been several attempts to release 5.0.0.Alpha1 already. None of them appeared in Maven Central, but the commits are there. Not sure what to do about this...?

With no release in Central and no tag either, does it matter?

@Ladicek
Copy link
Contributor Author

Ladicek commented May 22, 2024

Good point, I didn't notice there's no tag. I'll move back to 5.0.0.Alpha1-SNAPSHOT.

@Ladicek
Copy link
Contributor Author

Ladicek commented May 22, 2024

Done.

@manovotn manovotn merged commit 778d0bf into jakartaee:main May 24, 2024
3 checks passed
@Ladicek Ladicek deleted the updates branch May 27, 2024 07:10
@manovotn manovotn mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt approved these changes

@manovotn manovotn manovotn approved these changes

@starksm64 starksm64 Awaiting requested review from starksm64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ladicek @manovotn @Azquelt