Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move over entirely to the new Actions YAML syntax #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chabad360
Copy link

This PR almost entirely removes the need for the env section in the workflow config (now it's only needed for PURGE_URLS) and transfers everything over to the with section (see the modified readme for details).

@jakejarvis
Copy link
Owner

Thanks @chabad360, this all looks good to me!

Unfortunately I'll need to hold off on merging because I had attempted to move the metadata from action.yml into Dockerfile in the past and it blocked me from publishing to the Action Marketplace.... Very, very weird but I sent a support ticket and have a thread on the forums (no response there yet) and I'll update you when I hear back from GitHub. Thanks again!!

@chabad360
Copy link
Author

chabad360 commented Oct 17, 2019

Yup, I discovered that the hard way too, turns out that as of last week the HCL (i.e. docker metadata) syntax is no longer supported (remember, Actions are after all only in beta). I had to migrate my Action as well (it was a pain, but now I feel almost like an expert in such migrations)...

But honestly, I really think the YAML format is better, it keeps things separate and cleaner...

@chabad360
Copy link
Author

If you don't mind, I'll post a more detailed response on that forum post soon

@jakejarvis
Copy link
Owner

Sure thing! 👍

@chabad360
Copy link
Author

So this can be merged then?

@chabad360
Copy link
Author

any update on if this can be merged?

@RReverser
Copy link

@jakejarvis Sorry to be that guy, but "+1" couple of months since the last update is hopefully appropriate :)

I want to use this action, but env doesn't seem very natural in modern Actions.

Is there anything still preventing this PR from being merged?

@deon-vector
Copy link

4 years later, any update on merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants