Skip to content

Commit

Permalink
version getter needs to be before getChangelogPoints - fix Android Pl…
Browse files Browse the repository at this point in the history
…ayStore crash
  • Loading branch information
jameskokoska committed Sep 28, 2023
1 parent 6564a86 commit 2556ac7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions budget/lib/widgets/showChangelog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ String getChangelogString() {
Hot fix for default wallet creation database lock
Fix SQL file selection on iOS limitation
Database corruption detection (if incorrect file imported)
Changelog version not getting updated
< 4.5.0
Can enable/disable homepage welcome banner
Feedback popup only shown if changelog is not
Expand Down Expand Up @@ -1503,6 +1502,8 @@ bool showChangelog(
bool majorChangesOnly = false,
Widget? extraWidget,
}) {
String version = packageInfoGlobal.version;

List<Widget>? changelogPoints = getChangelogPointsWidgets(
context,
forceShow: forceShow,
Expand All @@ -1512,7 +1513,6 @@ bool showChangelog(
: majorChangesOnly,
);

String version = packageInfoGlobal.version;
updateSettings(
"lastLoginVersion",
version,
Expand Down
2 changes: 1 addition & 1 deletion budget/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ publish_to: "none" # Remove this line if you wish to publish to pub.dev
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 4.5.1+209
version: 4.5.1+212

environment:
sdk: ">= 3.0.0"
Expand Down

0 comments on commit 2556ac7

Please sign in to comment.