Custom Exceptions break Class Based Views

example_project/core/views.py

@@ -3,8 +3,10 @@
 
 from django.http import Http404
 from django.shortcuts import render_to_response
+from django.views.generic import ListView
 
 from pure_pagination.paginator import Paginator
+from pure_pagination.mixins import PaginationMixin
 
 from core.names import names
 
@@ -31,4 +33,8 @@ def index(request):
         'page': page,
     })
 
-
+
+class List(PaginationMixin, ListView):
+    template_name = 'list.html'
+    paginate_by = 10
+    queryset = names

example_project/urls.py

@@ -1,5 +1,5 @@
 from django.conf.urls.defaults import patterns, include, url
-
+from core.views import List
 # Uncomment the next two lines to enable the admin:
 # from django.contrib import admin
 # admin.autodiscover()
@@ -16,4 +16,5 @@
     # url(r'^admin/', include(admin.site.urls)),
 
     url(r'^$', 'core.views.index', name="index"),
+    url(r'^list/$', List.as_view(), name="list"),
 )

pure_pagination/paginator.py

@@ -4,21 +4,13 @@
 import functools
 
 from django.template.loader import render_to_string
+from django.core.paginator import InvalidPage, PageNotAnInteger, EmptyPage
 
 PAGINATION_SETTINGS = getattr(settings, "PAGINATION_SETTINGS", {})
 
 PAGE_RANGE_DISPLAYED = PAGINATION_SETTINGS.get("PAGE_RANGE_DISPLAYED", 10)
 MARGIN_PAGES_DISPLAYED = PAGINATION_SETTINGS.get("MARGIN_PAGES_DISPLAYED", 2)
 
-class InvalidPage(Exception):
-    pass
-
-class PageNotAnInteger(InvalidPage):
-    pass
-
-class EmptyPage(InvalidPage):
-    pass
-
 class Paginator(object):
     def __init__(self, object_list, per_page, orphans=0, allow_empty_first_page=True, request=None):
         self.object_list = object_list

pure_pagination/tests.py

@@ -1,9 +1,12 @@
 from datetime import datetime
 from operator import attrgetter
 
-from pure_pagination import Paginator, InvalidPage, EmptyPage
+from pure_pagination import Paginator, InvalidPage, EmptyPage, PaginationMixin
+
 from django.test import TestCase
-from django.test.client import Client
+from django.test.client import Client, RequestFactory
+from django.views.generic import ListView
+from django.http import Http404
 
 from django.db import models
 
@@ -22,6 +25,11 @@ class LenContainer(object):
     def __len__(self):
         return 42
 
+class ArticleList(PaginationMixin, ListView):
+    paginate_by = 2
+    queryset = Article.objects.all()
+    template_name = "pure_pagination/pagination.html"
+
 class PaginationTests(TestCase):
     def setUp(self):
         # Prepare a list of objects for pagination.
@@ -142,5 +150,17 @@ def test_pagination_containing_percent_char(self):
         pass
 
     def test_mixins(self):
-        pass
-
+        factory = RequestFactory()
+
+        req = factory.get('/list')
+        resp = ArticleList(request=req, kwargs={}).get(req)
+        self.assertEqual(200, resp.status_code)
+
+        with self.assertRaises(Http404):
+            req = factory.get('/list?page=foo')
+            ArticleList(request=req, kwargs={}).get(req)
+
+        with self.assertRaises(Http404):
+            req = factory.get('/list?page=1000')
+            ArticleList(request=req, kwargs={}).get(req)
+

setup.py

@@ -3,7 +3,7 @@
 from setuptools import setup, find_packages
 
 setup(name='django-pure-pagination',
-      version='0.2',
+      version='0.2.2',
       author='James Pacileo',
       long_description = open('README.rst').read(),
       license='BSD',