404 instead of 500 error for no existing page on mixin #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this or any other solution for the EmptyPage raises 500 issue. |
|
There are several other issues opened for the same problem. #15 has a better solution (and testcases). Would be nice if that one could be pulled and a 1.2.2 be released on pypi... #13 does about the same, but it changeset doesn't look clean (whitespace/line endings changed?). #10 also the same solution, but it only removes 1 of the exception classes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a clean view from the final user, I added this to have a 404 error page if the page number does not exist instead of a 500 for the paginator mixin class