Bugfix: Only add event handler if link exists

jameswyse · Jul 23, 2013 · 0fb276b · 0fb276b
1 parent 75aec1e
commit 0fb276b
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 8 deletions.
diff --git a/dist/demo/index.html b/dist/demo/index.html
@@ -17,7 +17,7 @@
         <div class="row big">
             <div id="example1" class="imageReveal">
                 <img src="images/1-before.jpg" title="Sup">
-                <img src="images/1-after.jpg" title="After">
+                <img src="images/1-after.jpg" title="After" data-link="http://www.apple.com">
             </div>
         </div>
 
@@ -65,6 +65,7 @@
                     startPosition: 0.25,
                     showCaption: true,
                     captionChange: 0.5,
+                    linkCaption: true,
                     width: 500,
                     height: 500
                 });

diff --git a/dist/jquery.imageReveal.js b/dist/jquery.imageReveal.js
@@ -158,7 +158,7 @@
           .css('cursor', 'pointer')
           .data('link', $el[i].before.data('link'))
           .on('click', function() {
-            window.location = $el[i].caption.data('link');
+            if($el[i].caption.data('link')) window.location = $el[i].caption.data('link');
             return false;
           });
       }

diff --git a/dist/jquery.imageReveal.min.js b/dist/jquery.imageReveal.min.js
diff --git a/imageReveal.jquery.json b/imageReveal.jquery.json
@@ -1,6 +1,6 @@
 {
   "name": "imageReveal",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "title": "jQuery Image Reveal",
   "description": "A Simple Before/After Image Viewer",
   "keywords": [

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "jquery-image-reveal",
   "description": "jQuery Image Reveal - A Simple Before/After Image Viewer",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "homepage": "http://github.com/lemoncreative/jquery-image-reveal",
   "author": {
     "name": "Lemon Creative",

diff --git a/src/demo/index.html b/src/demo/index.html
@@ -17,7 +17,7 @@
         <div class="row big">
             <div id="example1" class="imageReveal">
                 <img src="images/1-before.jpg" title="Sup">
-                <img src="images/1-after.jpg" title="After">
+                <img src="images/1-after.jpg" title="After" data-link="http://www.apple.com">
             </div>
         </div>
 
@@ -65,6 +65,7 @@
                     startPosition: 0.25,
                     showCaption: true,
                     captionChange: 0.5,
+                    linkCaption: true,
                     width: 500,
                     height: 500
                 });

diff --git a/src/jquery.imageReveal.js b/src/jquery.imageReveal.js
@@ -158,7 +158,7 @@
           .css('cursor', 'pointer')
           .data('link', $el[i].before.data('link'))
           .on('click', function() {
-            window.location = $el[i].caption.data('link');
+            if($el[i].caption.data('link')) window.location = $el[i].caption.data('link');
             return false;
           });
       }