Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes, improve reader mode and ctrl+0 #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tmarkov
Copy link

@tmarkov tmarkov commented Nov 27, 2019

This PR contains 2 things:

  1. Bugfix: In onCreated, only set zoom to default if it's 1.
  2. Reset zoom to default every time it's changed to 1.
  • This fixes some glitches with reader mode and allows ctrl+0 to sent to default zoom
  • To be able to set zoom to 1 manually, the user can edit toolkit.zoomManager.zoomValues and change the 1 to 0.99 or 1.01.

You shouldn't merge both this and #8, I'm putting all my changes in one PR because I simplified the code a bit as well.

I won't close #8 in case you don't like the additional changes and want only the bugfix.

tmarkov added 2 commits November 27, 2019 18:00
Don't change zoom on new tab if it's not 1.
Reset zoom to default if changed to 1.
Recommend to replace 1 with 0.99 in toolkit.zoomManager.zoomValues
@tmarkov tmarkov changed the title Next Bugfixes, improve reader mode and ctrl+0 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant