Check highlight option in mouseover() instead of highlight(). #191
Conversation
This allow external methods to control the highlight status, just as it is possible to set isSelectable to false, and control the selection status from external methods. Effectively, mouseover() and mouseout() no long call the highlight() and clearEffects() methods if the highlight option is false. Also, the highlight() method now highlights the area, regardless of the highlight option. See jamietre#190.
Enforcing MS-DOS line-breaks.
|
Hello @macfreek - Thank you for your contribution, apologize for the long delay in responding! I've taken a look at #190 where you describe your objective with this PR. The first thing that comes to mind is that clearEffects also is responsible for closing tooltips, etc. so highlight isn't the only consideration here. With that said, happy to review this more closely. If you still have an interest in having this considered, please let me know and also, if you could, update your fiddles. I was able to make some adjustments based on what I thought you were trying to do but would much rather have you update them to be exactly what you were after so I don't misunderstand anything. Let me know your thoughts, thanks again!! |
|
Hi @techfg I suggest to close the PR. To anyone who comes across the same issue, feel free to re-use any part of the code that may still be relevant. I hereby release any part of my contribution in this PR as well as in the above Fiddles as public domain and/or creative commons zero (at your choice). |
|
Hi @macfreek - Thanks for getting back to me on this so quickly and again, apologies for the long delay in getting back to you on this PR. Per your comments, I'll go-ahead and close. Appreciate you releasing your contribution to the community for anyone that it might be helpful to. If you do decide to revisit the PR, please just let us know! |
See issue #190.
This allow external methods to control the highlight status, just as it is possible to set isSelectable to false, and control the selection status from external methods.
Effectively, mouseover() and mouseout() no long call the highlight() and clearEffects() methods if the highlight option is false. Also, the highlight() method now highlights the area, regardless of the highlight option.
Note: I did not add the build output (dist/jquery.imagemapster.js and dist/jquery.imagemapster.min.js). Part of the src in the original repository has MS-DOS line endings, some UNIX line endings, and rake can't handle that, leading to spurious lines in the diff.