ShellCheck: Add ${EXIT_ ... } into double quotes

jan-revay · Aug 2, 2024 · e9b5c70 · e9b5c70
1 parent 23daee7
commit e9b5c70
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/Android_13/configs_install.sh b/Android_13/configs_install.sh
@@ -9,8 +9,8 @@ fi
 
 touch ~/.bashrc # Termux does not create .bashrc by default but some scripts use it
 
-pushd ../CommonInitScripts/ || exit ${EXIT_FILE_IO_ERROR}
+pushd ../CommonInitScripts/ || exit "${EXIT_FILE_IO_ERROR}"
 # TODO cd in sharedConfig.sh
 # shellcheck source=/dev/null
 . sharedConfig.sh
-popd || exit ${EXIT_FILE_IO_ERROR}
+popd || exit "${EXIT_FILE_IO_ERROR}"
diff --git a/Android_13/run_all.sh b/Android_13/run_all.sh
@@ -5,7 +5,7 @@
 
 if ! uname -a | grep Android; then
     echo The init script does not run on Android
-    exit ${EXIT_INCORRECT_PLATFORM}
+    exit "${EXIT_INCORRECT_PLATFORM}"
 fi
 
 if ! gh auth status; then

diff --git a/UbuntuCLI/configs_install.sh b/UbuntuCLI/configs_install.sh
@@ -3,11 +3,11 @@
 
 . ../prelude.sh
 
-pushd ../CommonInitScripts/ || exit ${EXIT_FILE_IO_ERROR}
+pushd ../CommonInitScripts/ || exit "${EXIT_FILE_IO_ERROR}"
 # TODO cd in sharedConfig.sh
 # shellcheck source=/dev/null
 . sharedConfig.sh
-popd || exit ${EXIT_FILE_IO_ERROR}
+popd || exit "${EXIT_FILE_IO_ERROR}"
 
 # ==== Misc ====
 sudo update-alternatives --set editor /usr/bin/nvim
diff --git a/UbuntuCLI/interactive_part.sh b/UbuntuCLI/interactive_part.sh
@@ -30,7 +30,7 @@ if [ "$1" = "--help" ]; then
     echo
     # shellcheck disable=SC2016
     echo '--noninteractive  skip stuff requiring user interaction (e.g. `gh auth login`)'
-    exit ${EXIT_SUCCESS}
+    exit "${EXIT_SUCCESS}"
 fi
 
 if [ "$1" == "--noninteractive" ]; then
@@ -39,5 +39,5 @@ elif [ "$1" == "" ]; then
     interactive_part
 else
     echo "invalid argument $1"
-    exit ${EXIT_INVALID_ARGUMENT}
+    exit "${EXIT_INVALID_ARGUMENT}"
 fi