fix: traversal limit ignoring default value #66
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
The
moduleParsed
hook calls out togetCorrespondingPackageFromModuleId
for each imported module, which tries to find apackage.json
to extract information from. If it can't find apackage.json
it should traverse up the directory tree a max of 10 times before failing.The current implementation passes
getCorrespondingPackageFromModuleId
directly to thenodeModuleImportedIds.map()
call. This means that thetraverseLimit
param will not beundefined
and use the default of 10, and instead will be the current index in the array (the second param of.map()
). We found this meant a number of packages were getting missed in our output SBOM.This pull request uses an arrow function to call
getCorrespondingPackageFromModuleId
, which will correctly use the default value of 10.