Update to new JavaScript-Promise Integration API

[vouillon]

No description provided.

[rickyvetter]

When I tried this I get an error in node v23.0.0-v8-canary2024100880fe21ab46:

RuntimeError: attempting to suspend without a WebAssembly.promising export

Reading https://github.com/WebAssembly/js-promise-integration/blob/main/proposals/js-promise-integration/Overview.md, I think there is more work required. We need to implement the promising part of the pair, which is awkward because I don't think there is current machinery for inserting JavaScript code into the runtime which has access to some corresponding wasm export values.

Did you run into this error? Which version of node were you running against if not?

[vouillon]

I think you need ocaml-wasm/wasm_of_ocaml#48 as well.
I have tested with an older version of node, v23.0.0-v8-canary2024070398c15bef2c, which supports both APIs.

[rickyvetter]

Ahh yes. With ocaml-wasm/wasm_of_ocaml#48 this does look good!

[rickyvetter]

I've noticed that I do get an error when running with whole program compilation and aggressive wasm-metadce passes on tests that don't use effects. I can resolve by editing https://github.com/ocaml-wasm/wasm_of_ocaml/blob/main/runtime/wasm/deps.json#L4 to include "effects", which I think is the correct fix? It might make more sense to try and generate deps.json somehow?

[vouillon]

Actually, we don't need caml_start_fiber for tests that don't use effects. The issue is that make_promising is failing when passed an undefined value. I have pushed a fix to ocaml-wasm/wasm_of_ocaml#48.