Skip to content

Commit

Permalink
deactivate separate test publish step (#230)
Browse files Browse the repository at this point in the history
  • Loading branch information
jannikmi authored Jun 14, 2024
1 parent 208f663 commit 5feeee6
Showing 1 changed file with 36 additions and 30 deletions.
66 changes: 36 additions & 30 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,45 @@ jobs:
name: artifact-source-dist
path: "./**/dist/*.tar.gz"

# test-publish:
# name: Test PyPI Publishing
# runs-on: ubuntu-latest
# needs: [test, make-wheels, make-sdist]
# # only run jobs if the feature branch is the base repo (not in a fork)
# # TODO separate step, fails PRs from forks due to: "missing or insufficient OIDC token permissions,
# # the ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variable was unset"
# if: github.event.pull_request.head.repo.full_name == github.repository
# permissions:
# id-token: write
# contents: write
# steps:
# - name: Fetch version
# id: fetch_version
# run: echo "version_nr=$(poetry version -s)" >> $GITHUB_OUTPUT
#
# - name: Download all artifacts
# uses: actions/download-artifact@v4
#
# - name: Copy artifacts to dist/ folder
# run: |
# find . -name 'artifact-*' -exec unzip '{}' \;
# mkdir -p dist/
# find . -name '*.tar.gz' -exec mv '{}' dist/ \;
# find . -name '*.whl' -exec mv '{}' dist/ \;
# ls -lR dist/
#
# - name: Test PyPI Publishing
# uses: pypa/gh-action-pypi-publish@release/v1
# with:
# password: ${{ secrets.TEST_PYPI_DEPLOYMENT_API_KEY }}
# repository-url: https://test.pypi.org/legacy/
# skip-existing: true

test-publish:
name: Test PyPI Publishing
publish:
runs-on: ubuntu-latest
# Note: TODO only run, when test publishing worked
needs: [test, make-wheels, make-sdist]
# only run jobs if the feature branch is the base repo (not in a fork)
# TODO fails PRs from forks due to: "missing or insufficient OIDC token permissions,
# the ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variable was unset"
if: github.event.pull_request.head.repo.full_name == github.repository
if: endsWith(github.ref, '/master')
permissions:
id-token: write
contents: write
Expand All @@ -132,30 +162,6 @@ jobs:
repository-url: https://test.pypi.org/legacy/
skip-existing: true

publish:
runs-on: ubuntu-latest
# Note: only runs, when test publishing worked
needs: [test, make-wheels, make-sdist, test-publish]
if: endsWith(github.ref, '/master')
permissions:
id-token: write
contents: write
steps:
- name: Fetch version
id: fetch_version
run: echo "version_nr=$(poetry version -s)" >> $GITHUB_OUTPUT

- name: Download all artifacts
uses: actions/download-artifact@v4

- name: Copy artifacts to dist/ folder
run: |
find . -name 'artifact-*' -exec unzip '{}' \;
mkdir -p dist/
find . -name '*.tar.gz' -exec mv '{}' dist/ \;
find . -name '*.whl' -exec mv '{}' dist/ \;
ls -lR dist/
- name: Create GitHub Release
id: create_gh_release
uses: ncipollo/release-action@v1
Expand Down

0 comments on commit 5feeee6

Please sign in to comment.