Add --xdebug option and xdebug.dockerfile #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckappelhoff
reviewed
Sep 29, 2020
|
|
||
| RUN pecl install xdebug-2.9.8 \ | ||
| && docker-php-ext-enable xdebug \ | ||
| && echo "xdebug.remote_host = 10.254.254.254" >> /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini \ |
There was a problem hiding this comment.
Woher kommt die IP-Adresse?
Du kannst die DNS host.docker.internal angeben, über die Container immer den Host erreichen (https://docs.docker.com/docker-for-windows/networking/).
| @@ -0,0 +1,49 @@ | |||
| FROM ${DOCKERIZE_BASE_IMAGE} | |||
There was a problem hiding this comment.
Ich würde empfehlen Multi-Stage Builds zu verwenden, damit wir kein duplizierten Code haben.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@janole It would be nice to have the option to easily do
php artisan docker:bwith Xdebug for local development.I propose to add a
-X|--xdebugoption.I'm not so sure if adding a second Dockerfile is the best options though. What do you think?