Improve AOT mode (on RISC-V) w.r.t calls #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aw bytes This commit changes the way assembler input is generated in AOT mode. Instead of writing instruction as raw `.byte`s, write normal assembly. This means we must not fixup branches in AOT mode in order to keep them symbolic. This change not only improves readability by also (will) enable generation of more advanced AOT code (using PLT for calls, relocatable static data and so on)
This commit improves support for source / bytecode locations in AOT mode
in two ways:
* write bytecode indices in generate assembly
* write location pseudo-instructions / comments only when they change
(and not for each instruction).
This improves readability of generated assembly source.
...that is, functions whose return type is void.
This commit adds support for calling external (in a sense external to current compilation) functions in AOT mode. Since we're deferring object file creation to GNU assembler, we need to generate `call` pseudo instruction in order for assembler and linker to create appropriate relocations and PLT thunks. To do so, we introduce a new RISC-V specific pseudo instruction: `AcRISCVCall` which behaves as `auipc` + `jalr` pair when used in JIT mode. This hack may be removed once we move away from generating GNU assembler source towards creating object file directly.
|
My comments on this are of mostly-philosophical nature. Let's address them in 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.