feat: 登録削除コマンド "vcspeaker remove" の追加 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
book000
commented
Jul 6, 2024
book000
commented
- close サーバ登録解除コマンドが存在しない #12
yuuahp
reviewed
Jul 7, 2024
There was a problem hiding this comment.
一応確認とかほしくないですか？
「すべて削除しますけどよろしいですか？戻せませんよ？」
みたいな
あと Guild ごとのデータって Alias とか Ignore とかもありますが、そこらへんは削除しませんか？
There was a problem hiding this comment.
まあ、たしかに。
/vcspeaker remove confirm とか追加で叩かせるようにしますか？
Alias, Ignoreの削除については不足しているので追加します。
There was a problem hiding this comment.
あーそうか、テキストコマンドは無いからボタンインタラクションとか使えるのか…。
そっちのほうがいいですね
There was a problem hiding this comment.
確認処理と、エイリアスとかの情報削除処理を追加しました。
こういうのもテストコード書きたいですね、モックの書き方含め、よくわからんですけど…。
確認処理画面
「はい」を選択した場合
「いいえ」を選択した場合
|
yuuahp
requested changes
Jul 7, 2024
src/main/kotlin/com/jaoafa/vcspeaker/commands/VCSpeakerCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jaoafa/vcspeaker/commands/VCSpeakerCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/jaoafa/vcspeaker/commands/VCSpeakerCommand.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: yuuaHP <[email protected]>
yuuahp
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.