Fix unhandled EPIPE error leading to language server crashes #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneSchulze
commented
May 14, 2023
| @@ -34,7 +34,7 @@ let execFull = (~input=?, ~pwd=?, ~env=Unix.environment(), cmd) => { | |||
| | None => () | |||
| | Some(text) => output_string(cmd_in, text) | |||
| }; | |||
| close_out(cmd_in); | |||
There was a problem hiding this comment.
close_out would trigger a Sys_error("Broken pipe") exception now that we ignore the SIGPIPE signal. Instead of catching and handling it, we simply use close_out_noerr which ignores all errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of ocaml when receiving a
SIGPIPEsignal is to terminate the program. Processes opened inCommands.reit can exit prematurely causing anEPIPEerror which triggers theSIGPIPEsignal leading the language server process to terminate. To circumvent that we tell OCaml to ignoreSIGPIPEs.t. the error can be handled when interacting with the channels/file-descriptors inCommands.