You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original example did not render the children prop, which resulted in the select element not displaying the options passed as children. This PR updates the MySelect component to properly handle the children prop and render the options inside the dropdown.
Changes Made
Updated MySelect component to include the children prop inside the select element.
This ensures that the options passed as children (e.g., tags) are correctly displayed in the dropdown list.
Issue Addressed
Incorrect example in the documentation where options passed to the MySelect component were not being rendered.
Testing
Verified that the options now render correctly in the MySelect component by testing it with the provided example from the tutorial.
Additional Notes
This PR only fixes the example in the docs and does not introduce any breaking changes.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rohitKumar38344
requested review from
jaredpalmer and
quantizor
as code owners
The original example did not render the children prop, which resulted in the select element not displaying the options passed as children. This PR updates the MySelect component to properly handle the children prop and render the options inside the dropdown.
Changes Made
Updated MySelect component to include the children prop inside the select element.
This ensures that the options passed as children (e.g., tags) are correctly displayed in the dropdown list.
Issue Addressed
Incorrect example in the documentation where options passed to the MySelect component were not being rendered.
Testing
Verified that the options now render correctly in the MySelect component by testing it with the provided example from the tutorial.
Additional Notes
This PR only fixes the example in the docs and does not introduce any breaking changes.