Remove reduce error throwing
#1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,9 +122,6 @@ | |||
| ok(_.reduce(null, _.noop, 138) === 138, 'handles a null (with initial value) properly'); | |||
| equal(_.reduce([], _.noop, undefined), undefined, 'undefined can be passed as a special case'); | |||
| equal(_.reduce([_], _.noop), _, 'collection of length one with no initial value returns the first item'); | |||
|
|
|||
| throws(function() { _.reduce([], _.noop); }, TypeError, 'throws an error for empty arrays with no initial value'); | |||
There was a problem hiding this comment.
Could you update these tests to prove they don't throw
jridgewell
force-pushed
the
remove-reduce-errors
branch
from
94b2961 to
f1428a9
Compare
jridgewell
force-pushed
the
remove-reduce-errors
branch
from
f1428a9 to
41555ff
Compare
| memo = obj[keys ? keys[--index] : --index]; | ||
| } | ||
| while (index--) { | ||
| while (index-- > 0) { |
There was a problem hiding this comment.
I prefer to never use the result of a postfix increment/decrement (or use them at all). Let's do while(--index >= 0).
jashkenas
added a commit
that referenced
this pull request
Dec 11, 2014
Remove `reduce` error throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1858.