Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

Async/Await + Libasynql #465

Draft
wants to merge 47 commits into
base: API4
Choose a base branch
from
Draft

Async/Await + Libasynql #465

wants to merge 47 commits into from

Conversation

jasonw4331
Copy link
Owner

Introduction

The existing MyPlot implementation is very heavily single threaded and relies on the cache too much.

Relevant issues

  • N/A

Changes

API changes

TODO

Behavioral changes

90% of the API is converted to an async/await structure

Backwards compatibility

There are many BC breaks in the conversion from a synchronous to an asynchronous API. The major version will be bumped to indicate the changes.

Follow-up

TODO

Tests

TODO

@jasonw4331
Swapped data storage to use libasynql
ac6939c
@jasonw4331
Converted save function to async/await format
65f8781
@jasonw4331
Converted getPlotsOfPlayer function to async/await format
88c6948
@jasonw4331
Converted getNextFreePlot function to async/await format
49d326d
@jasonw4331
Converted getPlotByPosition function to async/await format
a03fad9
@jasonw4331
Converted getPlotPosition function to async/await format
21801d3
@jasonw4331
Converted isPositionBorderingPlot function to async/await format
0042529
@jasonw4331
Converted getPlotBorderingPosition function to async/await format
b13d409
@jasonw4331
Converted getPlotBB function to async/await format
73d357d
@jasonw4331
Converted renamePlot function to async/await format
430bca7
@jasonw4331
Fixed getPlotBorderingPosition missing its promise resolution
48b4a6e
@jasonw4331
Converted disposePlot to async/await format
5e5ce0b
@jasonw4331
Converted claimPlot to async/await format
5599012
@jasonw4331
Added missing function param
58ecfc4
@jasonw4331
Added some utility functions for more generators
f2f2473
@jasonw4331
use new utility functions in getPlotBB
aec3814
@jasonw4331
publicize getPlotFast for a non-async way to get a plot object
3f120c1
@jasonw4331
Updated clonePlot to Async/Await format
87d5e37
@jasonw4331
Updated clearPlot to Async/Await format
73be908
@jasonw4331
Updated resetPlot to Async/Await format
339bcf1
@jasonw4331
Updated setPlotBiome to Async/Await format
bff40b5
@jasonw4331
Updated setPlotPvp to Async/Await format
b15e883
@jasonw4331
Updated addPlotHelper to Async/Await format
aa8cc79
@jasonw4331
Updated removePlotHelper to Async/Await format
50f3ef8
@jasonw4331
Updated addPlotDenied to Async/Await format
ff11da3
@jasonw4331
Updated removePlotDenied to Async/Await format
3d623cb
@jasonw4331
Updated buyPlot to Async/Await format
0481a83
@jasonw4331
Updated mergePlots to Async/Await format
b06d1b1
@jasonw4331
Updated sellPlot to Async/Await format
ccd237d
@jasonw4331 jasonw4331 added the API 4 This pertains to PocketMine's API 4.x.y changes in comparison to API 3.x.y label Feb 5, 2022
@jasonw4331 jasonw4331 added BC-Breaks This pertains to backwards compatibility breaks in the API Category: Enhancement This makes the code quality better PR: Feature Additions Status: Major Changes Needed Status: Work In Progress labels Feb 5, 2022
@jasonw4331 jasonw4331 self-assigned this Feb 5, 2022
@jasonw4331 jasonw4331 changed the base branch from master to API4 February 5, 2022 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jasonw4331 jasonw4331

Labels
API 4 This pertains to PocketMine's API 4.x.y changes in comparison to API 3.x.y BC-Breaks This pertains to backwards compatibility breaks in the API Category: Enhancement This makes the code quality better PR: Feature Additions Status: Major Changes Needed Status: Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonw4331 @AIPTU