Add unwind info manager implementation and use it #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That acts as a transparent disk cache for unwind information Test Plan ========= Added tests + see next commit
Test Plan ========= Ran the profiler for a while without any issues
javierhonduco
changed the title
javierhonduco
commented
Jan 8, 2025
| @@ -118,8 +117,7 @@ pub enum ReaderError { | |||
| Digest, | |||
| } | |||
|
|
|||
| /// Reads compact information of a bytes slice. | |||
There was a problem hiding this comment.
Oops must have removed it while rebasing, will re-add it
| @@ -39,27 +39,26 @@ unsafe impl Plain for Header {} | |||
| /// read path, in case the data is corrupted. | |||
| unsafe impl Plain for CompactUnwindRow {} | |||
|
|
|||
| /// Writes compact information to a given writer. | |||
There was a problem hiding this comment.
Oops must have removed it while rebasing, will re-add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.