Upgrade triton dependency to dev20230822 nightly #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-chuang
force-pushed
the
jon-chuang/upgrade-triton
branch
from
84c0593
to
df95f36
Compare
|
Thank you for this change! This is really helpful! The main issue is that we mirror Triton internally at Google and haven't updated to latest triton yet. JAX-Triton is kept in sync with the Triton in Google. When we update Triton (which we should do soon), we can land your PR. |
jon-chuang
commented
Sep 6, 2023
jon-chuang
force-pushed
the
jon-chuang/upgrade-triton
branch
from
c340af0
to
04f5ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Triton dep is 1.5 months old.
While one should not attempt to update regularly, I think its about time to upgrade due to breaking API changes as well as benefit from Triton improvements (see for instance in jax-ml/jax#17328 (comment) - about 25% speedup in flash attention for the given tile size due to fixes on Triton side)