Added CI job with TSAN and free-threading #24898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
force-pushed
the
add-tsan-ft-ci-job
branch
6 times, most recently
from
193ce0e to
d24c068
Compare
vfdev-5
force-pushed
the
add-tsan-ft-ci-job
branch
2 times, most recently
from
9ce2358 to
3c1d272
Compare
vfdev-5
force-pushed
the
add-tsan-ft-ci-job
branch
3 times, most recently
from
5af2207 to
d99e3b6
Compare
vfdev-5
force-pushed
the
add-tsan-ft-ci-job
branch
4 times, most recently
from
b7a1299 to
baa17d2
Compare
This was referenced Dec 19, 2024
Updated pip and packaging versions to work with free-threading packages
bazelbuild/rules_python#2514
Merged
github-merge-queue bot
pushed a commit
to bazelbuild/rules_python
that referenced
this pull request
Jan 3, 2025
…es (#2514) We had an issue to install jaxlib with bazel when running the following command (using rules_python v0.39): ```bash bazel test \ --repo_env=HERMETIC_PYTHON_VERSION=3.13-ft \ --repo_env=JAX_NUM_GENERATED_CASES=$JAX_NUM_GENERATED_CASES \ --repo_env=JAX_ENABLE_X64=$JAX_ENABLE_X64 \ --repo_env=JAX_SKIP_SLOW_TESTS=$JAX_SKIP_SLOW_TESTS \ --repo_env=PYTHON_GIL=$PYTHON_GIL \ --repo_env=TSAN_OPTIONS="halt_on_error=1" \ --//jax:build_jaxlib=false \ --nocache_test_results \ --test_output=all \ //tests:cpu_tests ``` According to @vam-google, this was due to old pip/packaging versions. We updated them and this helped to make work the whole building/testing pipeline: jax-ml/jax#24898 So, we would like to upstream the patch: https://github.com/jax-ml/jax/pull/24898/files#diff-e3dc8d7d2bf5d057f95b86bcff7360b6c99fa1f458882fd112b58da4aceb53e4
vfdev-5
force-pushed
the
add-tsan-ft-ci-job
branch
from
baa17d2 to
7bbe81a
Compare
vfdev-5
force-pushed
the
add-tsan-ft-ci-job
branch
from
7bbe81a to
b1adb5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Depends on Avoid adding conflicting--repo_env=HERMETIC_PYTHON_VERSION=to bazel command #25527Depends on Updated rules_python pip/packaging versions with a patch openxla/xla#20723temporarily updated WORKSPACE, this can be removed once merged: Bumped rules_python version to 0.39.0 openxla/xla#19346We can update building options and remove--bazel_options=--@nanobind//:enabled_free_threading=Trueonce Replace custom free-threading flag by rules_python is_py_freethreaded in Nanobind openxla/xla#19669 is merged