umpProgram() with single bank number

jazz-soft · Nov 30, 2024 · 02a4e08 · 02a4e08
1 parent a96a08e
commit 02a4e08
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -68,15 +68,15 @@ by running `npm remove midi-test --save-dev`.
 
 ```html
 <script src="https://cdn.jsdelivr.net/npm/jzz"></script>       // the latest version, or
-<script src="https://cdn.jsdelivr.net/npm/[email protected].6"></script> // any particular version
+<script src="https://cdn.jsdelivr.net/npm/[email protected].7"></script> // any particular version
 //...
 ```
 
 ##### CDN (unpkg)
 
 ```html
 <script src="https://unpkg.com/jzz"></script>       // the latest version, or
-<script src="https://unpkg.com/[email protected].6"></script> // any particular version
+<script src="https://unpkg.com/[email protected].7"></script> // any particular version
 //...
 ```
 

diff --git a/javascript/JZZ.js b/javascript/JZZ.js
@@ -14,7 +14,7 @@
 })(this, function() {
 
   var _scope = typeof window === 'undefined' ? global : window;
-  var _version = '1.8.6';
+  var _version = '1.8.7';
   var i, j, k, m, n;
 
   /* istanbul ignore next */
@@ -3192,8 +3192,9 @@
     },
     umpProgram: function(g, c, n, msb, lsb) {
       return typeof msb == 'undefined' && typeof lsb == 'undefined' ?
-        [0x40 + _4b(g), 0xc0 + _ch(c), 0, 0, _7bn(n), 0, 0, 0] :
-        [0x40 + _4b(g), 0xc0 + _ch(c), 0, 1, _7bn(n), 0, _7bn(msb), _7bn(lsb)];
+        [0x40 + _4b(g), 0xc0 + _ch(c), 0, 0, _7bn(n), 0, 0, 0] : typeof lsb == 'undefined' ?
+        [0x40 + _4b(g), 0xc0 + _ch(c), 0, 1, _7bn(n), 0, _msb(msb), _lsb(msb)] :
+        [0x40 + _4b(g), 0xc0 + _ch(c), 0, 1, _7bn(n), 0, _7b(msb), _7b(lsb)];
     },
     umpPitchBend: function(g, c, x, y, z, w) {
       return [0x40 + _4b(g), 0xe0 + _ch(c), 0, 0].concat(_32a(x, y, z, w));

diff --git a/minified/JZZ.js b/minified/JZZ.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jzz",
-  "version": "1.8.6",
+  "version": "1.8.7",
   "description": "MIDI library for Node.js and web-browsers",
   "main": "javascript/JZZ.js",
   "scripts": {
@@ -22,13 +22,13 @@
     "jazz-midi": "^1.7.9"
   },
   "devDependencies": {
-    "eslint": "^9.9.1",
+    "eslint": "^9.16.0",
     "grunt": "^1.6.1",
     "grunt-contrib-jshint": "^3.2.0",
     "grunt-contrib-uglify": "^5.2.2",
     "midi-test": "^1.3.1",
-    "mocha": "^10.7.3",
-    "nyc": "^17.0.0",
+    "mocha": "^10.8.2",
+    "nyc": "^17.1.0",
     "web-audio-test": "^0.0.8",
     "web-midi-test": "^1.2.8"
   },

diff --git a/test/common.js b/test/common.js
@@ -1080,7 +1080,7 @@ describe('UMP messages', function() {
   it('umpProgram', function() {
     assert.equal(JZZ.UMP.umpProgram(1, 2, 3).toString(), '41c20000 03000000 -- Program Change');
     assert.equal(JZZ.UMP.umpProgram(1, 2, 3, 4, 5).toString(), '41c20001 03000405 -- Program Change');
-    assert.throws(function() { JZZ.UMP.umpProgram(1, 2, 3, 4); });
+    assert.equal(JZZ.UMP.umpProgram(1, 2, 3, 517).toString(), '41c20001 03000405 -- Program Change');
   });
   it('umpRPN', function() {
     assert.equal(JZZ.UMP.umpRPN(1, 2, 3, 4, 5).toString(), '41220304 00000005 -- Registered Controller');

diff --git a/web-midi-api/package.json b/web-midi-api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "web-midi-api",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "description": "Web MIDI API for Node.js",
   "main": "index.js",
   "scripts": {
@@ -13,7 +13,7 @@
     "web-midi-api"
   ],
   "dependencies": {
-    "jzz": "^1.8.6"
+    "jzz": "^1.8.7"
   },
   "contributors": [
     {