Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96 fix cache invalidation #110

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Conversation

adilhussain540
Copy link
Contributor

Description

  • Introduce BaseQueryset to make sure cache gets deleted after bulk operations.
  • Test bulk operations in models.

This PR addresses the cache invalidation-related bugs pointed out in #96

@adilhussain540 adilhussain540 self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c90289) 95.43% compared to head (3d53512) 96.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   95.43%   96.08%   +0.65%     
==========================================
  Files          12       12              
  Lines         394      409      +15     
  Branches       64       70       +6     
==========================================
+ Hits          376      393      +17     
+ Misses         13       11       -2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adilhussain540 adilhussain540 marked this pull request as ready for review December 7, 2023 07:53
Copy link
Collaborator

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Please extend the tests and add some assertions on the return values of the bulk methods :)

cookie_consent/models.py Outdated Show resolved Hide resolved
@sergei-maertens sergei-maertens merged commit fc0c6af into master Dec 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants