-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
96 fix cache invalidation #110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 95.43% 96.08% +0.65%
==========================================
Files 12 12
Lines 394 409 +15
Branches 64 70 +6
==========================================
+ Hits 376 393 +17
+ Misses 13 11 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
bbbc594
to
e3d4781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Please extend the tests and add some assertions on the return values of the bulk methods :)
93abd02
to
3d53512
Compare
Description
This PR addresses the cache invalidation-related bugs pointed out in #96