-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Django 5.0 #583
Test Django 5.0 #583
Conversation
Apologies for the initially wrong title, that will have caused duplicate-looking threads on email. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 6 6
Lines 796 796
=======================================
Hits 757 757
Misses 39 39 ☔ View full report in Codecov by Sentry. |
Hey @adamchainz could you possible merge |
1cf6a76
to
2708023
Compare
I rebased rather than merging, but yes now it’s up to date! |
Hey @adamchainz thanks for the work. I just merged your PR and tried to push a new release to pypi. It seems there is a release gh workflow: https://github.com/jazzband/django-model-utils/actions/runs/7856043884/job/21438400809 but it doesn't seem to work. Do you happen to know more? |
I have no idea, sorry. I'm no maintainer. |
hey @carljm, are you the original author of this library? After merging Adam's work I tried to push out a new release, but it looks like the release script doesn't fully work anymore: https://github.com/jazzband/django-model-utils/actions/runs/7856043884/job/21438400809 do you have any idea wat could go wrong here? |
@shanx I am the original author, but I have neither used the project nor been involved in maintenance for at least 8 years. I'm afraid I don't know anything about how that publish script works or what went wrong with it. I am willing to collaborate as needed in handoff steps to a responsible maintainer, but beyond that I don't have any interest in maintaining django-model-utils. Sorry! |
I totally understand that @carljm. I thought the spend a bit of time on this, get a release out there. But also don't have time to really dive into things. I see jazzband has the possibility to get help on a new release to pypi, I'll give that a shot. Anyway thanks for answering and have a beautiful day. |
@adamchainz a release was just pushed to pypi by @charettes. Thanks everyone! |
Problem
Test the new version of Django that’s in beta.
Depends on #582. If you want to consider updating
SaveSignalHandlingModel
, we can look at that, but I really suggest that it be removed.Solution
Added classifier to
setup.py
, new test environment totox.ini
, setup, and upgraded test requirements to fix some warnings.Commandments
CHANGES.rst
file to describe the changes, and quote according issue withGH-<issue_number>
.