Fixed an infinite recursion bug when deleting models related to a tracked model with a ForeignKey #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a model, that has a reverse relationship to a tracked model with SET_NULL on_delete
Problem
This issue arrises on these conditions:
on_delete=SET_NULL
(I believe also with PROTECT)When this happens, django loads the instance from the db with all fields deferred other than id. In this code,
we skip those deferred fields, but this is where the issue arrises, we don't check
self.field_map[field]
here, so even though the FK is deferred, we still attemp to load it, as we check for, as an example,foo
, while the deffered field isfoo_id
.Issue talked about here as well: #533